Dave
#activitypub #fedicasts The Podcast Index to ActivityPub bridge code is public now:
https://github.com/Podcastindex-org/pi-activitypub-server
This is still alpha software with much to do, but it's stable and working.
Episode and Live monitoring threads should now resurrect themselves if they panic, and it's way more tolerant of deserializing wonky AP JSON.
silverpill
Hi @dave
I tried to follow an actor and podcastindex server failed to process my Follow activity
Actor: https://ap.podcastindex.org/podcasts?id=920666
Inbox: https://ap.podcastindex.org/inbox?id=920666
Time: 2024-01-13T19:32:43Z
Response: http error 520
silverpill
@dave On Mitra side I see incoming Accept activity, but the server can't retrieve the public key:
HTTP status client error (400 Bad Request) for url (https://ap.podcastindex.org/podcasts)This is probably your instance actor. I tried to send a request manually, it still returns 400 Bad Request
Dave
@silverpill I'm getting an "invalid signature" back from Mitra when sending the Follow Accept request. Sending the Accept seems to generate a pingback from Mitra to the Accept'ing Actor's url but missing the url parameters to identify it.
I'm struggling to understand the flow that's happening which results in the invalid signature 401.
Log attached:
Dave
@silverpill Ty for reporting. I’ll grab a Mitra account and test.
silverpill
>but missing the url parameters to identify it.
Do you use query parameters? They are stripped
silverpill
Mitra tries to guess actor ID from key ID without making additional requests. Most of the time removing the fragment is enough, but some implementations use query parameter instead of fragment to identify the key, so these are removed too.
I think I can simply add exception for id query parameter if you prefer this URL structure.
silverpill
@dave Sorry, I think I was wrong about the instance actor. Mitra discovers actor by analyzing the keyId parameter in Signature HTTP header. If the value of this parameter contained URL with a query such as ?id=920666, it was removed, so only https://ap.podcastindex.org/podcasts remained.
I explained that in a subsequent reply:
https://mitra.social/objects/018d1433-67e4-028f-79b8-7ced5a7bad0c
The address of public.mitra.social instance actor is http://public.mitra.social/actor
Dave
@silverpill What is the actor instance url for public.mitra.social?
Dave
@silverpill I'm looking at it now to make adjustments. I'm seeing some confusing things out there about where/how an actor instance is actually discovered. If you have found your discovery method to be reliable then I think I should adapt to it.
silverpill
@dave Should I make an exception for id query parameter? This is not difficult, and as far as I know, using query parameters in actor IDs is perfectly valid according to AP spec - just not common.
Dave
@silverpill Thanks for that explanation. Will work on getting this handled tonight. 🙏
silverpill
@dave I'm testing it now, but I get error code: 520 in response to my Follow activity.
Dave
@silverpill Returning a proper Actor document for missing id param now, but still getting a 401 invalid signature on the Follow Accept. Here is the bridge's instance Actor url:
https://ap.podcastindex.org/podcasts (Mitra compatible)
Also, https://ap.podcastindex.org/podcasts?id=0 works.
Dave
@silverpill I guess if it’s not a violation of the spec then it makes sense to allow it on your side.
I’m finishing up the instance actor on my side since it wasn’t complete. I’m treating a missing id query param as the same as id=0, meaning instance actor.
silverpill
@dave Thanks! I un-followed and sent another follow request at 2024-01-17T17:49:35
Undo -> 200
Follow -> 520
Dave
@silverpill I have more logging in place now if you'd like to try following again when you get a chance.
Dave
@silverpill I see your testing and I'm adding more logging to help diagnose.
silverpill
@dave Made another attempt.
>missing field "name"
Maybe it is because some items in attachment array don't have this field?
Dave
@silverpill The 520 is happening here. I have added a response body log on that call so I can troubleshoot that deserialize issue if you can un-follow/follow one more time.
I'm zero'ing in. Lol.
silverpill
@dave I fixed signature validation (on mitra.social), and my follow request was processed correctly. Thank you!
Dave
@silverpill Yep, you nailed it. Attachment struct was too strict. Fixed now.
silverpill
@dave Yes, I'll make a bugfix release soon.
Dave
@silverpill Awesome!
I'm guessing that code will get pushed to public.mitra.social also once it's tested?
silverpill
@dave I released Mitra v2.7.2 and updated public.mitra.social
Successfully followed a Podcast Index actor from there.
By the way, what is the license under which pi-activitypub-server code is published? I didn't find a LICENSE file in the project repo
silverpill
@dave I stumbled upon another federation issue between Mitra and Podcast Index bridge.
There was a parsing error when I tried to load https://ap.podcastindex.org/episodes?id=6562175&statusid=f904fa9b-99d2-4b86-bee6-e0b29f1a734b&resource=post
After some digging I discovered that published field has wrong format: February 01, 2024 9:49pm. The correct format seems to be RFC 3339:
https://www.w3.org/TR/activitystreams-vocabulary/#dfn-published
https://www.w3.org/TR/xmlschema11-2/#dateTime
Dave
@silverpill Yay!!
I do MIT license on everything. Thanks for the heads up. I’ll add it to that repo.
０７６萌ＳＮＳ is a social network, courtesy of ０７６. It runs on GNU social, version 2.0.2-beta0, available under the GNU Affero General Public License.
All ０７６萌ＳＮＳ content and data are available under the Creative Commons Attribution 3.0 license.