Conversation

Notices

1. meso (meso@asbestos.cafe)'s status on Friday, 10-Feb-2023 05:09:09 JST meso

   • Alex Gleason
   • Mercurial Black
   @alex why :( this is not good for my boost power usering cc @MercurialBlack
   •  (mint@ryona.agency)'s status on Friday, 10-Feb-2023 05:09:08 JST 

     in reply to

     • Alex Gleason
     • Mercurial Black
     And I somehow don't get to choose, it goes straight to repost confirmation despite having `quote_posting` in metadata features list.
   •  (mint@ryona.agency)'s status on Friday, 10-Feb-2023 05:18:03 JST 

     in reply to

     • Alex Gleason
     • 
     • Mercurial Black
     @meso @alex @MercurialBlack Yeah, it doesn't check the feature list, instead only checking the version string plus separate `feature_quote` field from Fedibird.
     https://gitlab.com/soapbox-pub/soapbox/-/blob/develop/app/soapbox/utils/features.ts#L667
   •  (mint@ryona.agency)'s status on Friday, 10-Feb-2023 05:42:30 JST 

     in reply to

     • Alex Gleason
     • 
     • Mercurial Black

     @MercurialBlack @alex @meso This works.

     diff --git a/app/soapbox/utils/features.ts b/app/soapbox/utils/features.ts index 59ef9f4ad..7c3a34179 100644 --- a/app/soapbox/utils/features.ts +++ b/app/soapbox/utils/features.ts @@ -672,6 +672,7 @@ const getInstanceFeatures = (instance: Instance) => { */ quotePosts: any([ v.software === PLEROMA && [REBASED, AKKOMA].includes(v.build!) && gte(v.version, '2.4.50'), + features.includes('quote_posting'), instance.feature_quote === true, ]),

     Might be worth removing Rebased from version check as well, since I think all instances of it have quote_posting defined in features, only Akkoma acts like a special needs child in this regard. In either case, this would be of use for insane people like me who merged quote-post branch of upstream Pleroma instead of migrating. Too lazy to registed on Gitlab and make a proper pull request, sorry.

   • Alex Gleason (alex@gleasonator.com)'s status on Friday, 10-Feb-2023 05:44:34 JST Alex Gleason

     in reply to

     • 
     • Mercurial Black

     @mint @meso @MercurialBlack Ultimately we want this, but it got put a bit on the backburner. https://gitlab.com/soapbox-pub/soapbox/-/merge_requests/1914

      likes this.