Conversation

Notices

1. Lina Inver:z:e :mur_close: :nuts: (lina@eientei.org)'s status on Thursday, 09-Feb-2023 16:24:20 JST Lina Inver:z:e :mur_close: :nuts:

   • meso
   @meso i think those were added to pleroma by now? i can't be sure but eientei runs pleroma and watch this i can do custom emote reacts
   • Yukkuri (iamtakingiteasy@eientei.org)'s status on Thursday, 09-Feb-2023 16:24:14 JST Yukkuri

     in reply to

     • Yukkuri
     • meso
     @lina @meso Also looks like akkoma still can't handle new custom emoji reactions on a post that contains both unicode and custom reactions already.
     
     https://akkoma.dev/AkkomaGang/akkoma/pulls/386 -- trannies would rather have broken software than changes from the most racist, mysogenic and transphobic [formerly] akkoma instance.
      likes this.
   • Yukkuri (iamtakingiteasy@eientei.org)'s status on Thursday, 09-Feb-2023 16:24:15 JST Yukkuri

     in reply to

     • meso
     @lina @meso Yes, ported from akkoma also fixing some issues with mixing unicode and custom emojis;
     https://gitlab.eientei.org/eientei/pleroma/-/commits/pleroma-akkoma-emoji-port - BE
     https://gitlab.eientei.org/eientei/pleroma-fe/-/commits/pleroma-akkoma-emoji-port - FE
     
     Didn't tried to upstream it yet.
   • Lina Inver:z:e :mur_close: :nuts: (lina@eientei.org)'s status on Thursday, 09-Feb-2023 16:24:16 JST Lina Inver:z:e :mur_close: :nuts:

     in reply to

     • Yukkuri
     • meso
     @meso cc @iamtakingiteasy
   • meso (meso@asbestos.cafe)'s status on Thursday, 09-Feb-2023 16:24:18 JST meso

     in reply to
     @lina cc @eienteiadmin did you patch that or
   •  (mint@ryona.agency)'s status on Thursday, 09-Feb-2023 16:28:45 JST 

     in reply to

     • Yukkuri
     • meso
     @iamtakingiteasy @meso @lina Weird, I had no trouble reacting with both Unicode and custom emchichos on the same post despite the fact my backport likely doesn't contain fixes for that.
   •  (mint@ryona.agency)'s status on Thursday, 09-Feb-2023 16:32:17 JST 

     in reply to

     • Yukkuri
     • meso
     @iamtakingiteasy @meso @lina Looks like there's no issue with them as well.
     Screenshot_20230209_103112.png
   • Yukkuri (iamtakingiteasy@eientei.org)'s status on Thursday, 09-Feb-2023 16:32:19 JST Yukkuri

     in reply to

     • 
     • meso
     @mint @meso @lina It only applies for remote reactions, coming from another instance.
   • Yukkuri (iamtakingiteasy@eientei.org)'s status on Thursday, 09-Feb-2023 17:17:02 JST Yukkuri

     in reply to

     • 
     • Yukkuri
     • meso
     @mint @lina @meso Upstream akkoma at least still tries to parse it even if it is null, causing null dereference in this case
     https://akkoma.dev/AkkomaGang/akkoma/src/branch/develop/lib/pleroma/web/activity_pub/builder.ex#L93
     You can check if your sources are guarding against it, and see in object definition if url is indeed not defined for unicode emojis in object json
      likes this.
   • Yukkuri (iamtakingiteasy@eientei.org)'s status on Thursday, 09-Feb-2023 17:17:03 JST Yukkuri

     in reply to

     • 
     • meso
     @mint @meso @lina Interesting. Looks like your instance does account for emojis to not have a url when processing remote react.
   •  (mint@ryona.agency)'s status on Thursday, 09-Feb-2023 17:22:56 JST 

     in reply to

     • Yukkuri
     • meso
     @iamtakingiteasy @meso @lina Would apply the patch just in case, since I'm too lazy to properly test it especially since it seems to work regardless.
   •  (mint@ryona.agency)'s status on Thursday, 09-Feb-2023 17:23:58 JST 

     in reply to

     • Yukkuri
     • meso
     @lina @meso @iamtakingiteasy Xir have probably added you to the signed fetch shitlist.
   • Lina Inver:z:e :mur_close: :nuts: (lina@eientei.org)'s status on Thursday, 09-Feb-2023 17:23:59 JST Lina Inver:z:e :mur_close: :nuts:

     in reply to

     • 
     • Yukkuri
     • meso
     @iamtakingiteasy @meso @mint you know, speaking of -ACK!koma, did the troons writing it completely go off the radar? i stopped seeing ihatebeinga.live on the global timeline
   •  (mint@ryona.agency)'s status on Thursday, 09-Feb-2023 17:49:08 JST 

     in reply to

     • Yukkuri
     • meso
     @iamtakingiteasy @meso @lina Yep, now I see it, reactions just vanished.
   • Yukkuri (iamtakingiteasy@eientei.org)'s status on Thursday, 09-Feb-2023 17:49:09 JST Yukkuri

     in reply to

     • 
     • meso
     @mint @meso @lina If you haven't yet, try increasing reaction count on a custom emoji on that post locally.