Conversation

Notices

1. nixCraft 🐧 (nixcraft@mastodon.social)'s status on Wednesday, 27-Dec-2023 14:58:18 JST nixCraft 🐧

   What do YOU think makes a good Pull Request? 👇

   • Ray Hayes (rayhayes@mastodon.social)'s status on Wednesday, 27-Dec-2023 15:15:19 JST Ray Hayes

     in reply to

     @nixCraft Personally I think if you start to make it a rule-of-thumb that Pull Requests must be big or meaningful or good then it stops the natural breakdown of work into small chunks perhaps even just one line in one file.

   • Jack (funkyduck@fosstodon.org)'s status on Wednesday, 27-Dec-2023 15:18:59 JST Jack

     in reply to

     @nixCraft a good, clickbaity title, such as: "I removed these ten lines, you won't BELIEVE what happened next!"

   • nixCraft 🐧 (nixcraft@mastodon.social)'s status on Wednesday, 27-Dec-2023 15:18:59 JST nixCraft 🐧

     in reply to

     • Jack

     @funkyduck lol 😂

   • Achmadi (mekatronikachmadi@mastodon.social)'s status on Wednesday, 27-Dec-2023 16:38:09 JST Achmadi

     in reply to

     @nixCraft: its contain email where we can blame directly the person who send pull request

   • MegatronicThronBanks (megatronicthronbanks@mastodon.social)'s status on Wednesday, 27-Dec-2023 17:21:16 JST MegatronicThronBanks

     in reply to

     @nixCraft AS MUCH, friggn DETAIL, as possible!! WHY does it exist?? Tickets?? Why do it this WAY?

   • ryanvgates (ryanvgates@mastodon.social)'s status on Thursday, 28-Dec-2023 10:16:47 JST ryanvgates

     in reply to

     @nixCraft I would add to what's already been said, context for why the change is necessary.