Public
- Public
- Network
- Groups
- Popular
- People

Conversation

Notices

Esteban K�ber :rust: (ekuber@hachyderm.io)'s status on Wednesday, 04-Jan-2023 12:44:20 JST Esteban K�ber :rust:

Could I get feedback on this #rust compiler error? Even if (or maybe particularly if!) you're not familiar with #rustlang, can you understand what's happening? Are there things you'd change of this output?
In conversation Wednesday, 04-Jan-2023 12:44:20 JST from hachyderm.io permalink
Attachments
1. error[E0308]: mismatched types --> f57.rs:11:9 | 5 | let mut foo = vec![]; | ------ here the type is `Vec<_>` ... 8 | foo.push(i); | ---- here the type of `foo` is inferred to be `Vec<&i32>` ... 11 | bar(foo); | --- ^^^ expected `i32`, found `&i32` | | | arguments to this function are incorrect | = note: expected struct `Vec<i32>` found struct `Vec<&i32>` note: function defined here --> f57.rs:1:4 | 1 | fn bar(_: Vec<i32>) {} | ^^^ -----------
  https://media.hachyderm.io/media_attachments/files/109/622/152/178/076/845/original/75bd4f8058bc5bf2.png
- Esteban K�ber :rust: (ekuber@hachyderm.io)'s status on Wednesday, 04-Jan-2023 12:44:18 JST Esteban K�ber :rust:
  in reply to
  
  I think I've gotten to the best possible output for this #rust error that I can manage today, removing as much unnecessary context and being as localized as I can. And we got a bonus structured suggestion too!
  In conversation Wednesday, 04-Jan-2023 12:44:18 JST permalink
  Attachments
  1. error[E0308]: mismatched types --> f57.rs:13:9 | 10 | foo.push(i); | - this is of type `&i32`, which makes `foo` to be inferred as `Vec<&i32>` ... 13 | bar(foo); | --- ^^^ expected `i32`, found `&i32` | | | arguments to this function are incorrect | = note: expected struct `Vec<i32>` found struct `Vec<&i32>` note: function defined here --> f57.rs:1:4 | 1 | fn bar(_: Vec<i32>) {} | ^^^ ----------- help: consider dereferencing the borrow | 10 | foo.push(*i); | +
    https://media.hachyderm.io/media_attachments/files/109/628/825/613/598/979/original/a9a55ca4b89325b2.png
- Esteban K�ber :rust: (ekuber@hachyderm.io)'s status on Wednesday, 04-Jan-2023 12:44:19 JST Esteban K�ber :rust:
  in reply to
  
  Thank you everyone for your feedback. I've now filled two PRs. https://github.com/rust-lang/rust/pull/106400 for the change in the screenshot, and https://github.com/rust-lang/rust/pull/106399 to address the apparently very common issue of the primary label being misleading.
  In conversation Wednesday, 04-Jan-2023 12:44:19 JST permalink
  Attachments
  1. Point at expressions where inference refines an unexpected type by estebank · Pull Request #106400 · rust-lang/rust
    
    Address #106355.
  2. Modify primary span label for E0308 by estebank · Pull Request #106399 · rust-lang/rust
    
    Looking at the reactions to https://hachyderm.io/@ekuber/109622160673605438, a lot of people seem to have trouble understanding the current output, where the primary span label on type errors talks...
  Adrian Cochrane repeated this.

Public

Conversation

Notices

Feeds