Conversation

Notices

1. Zero :zt_think: :artix: (zero@strelizia.net)'s status on Friday, 19-May-2023 04:40:25 JST Zero :zt_think: :artix:
   >ForceMentionsInContent MRF enabled
   >notice nicecrew posts have no inline mentions
   >after some debugging I confirm the MRF is modifying the posts and adding inline mentions
   >default HTML scrubber doesn't have "span.recipients-inline" whitelisted, so the added mentions get removed, makes sense
   >add it and verify that the mentions don't get removed in the NormalizeMarkup MRF
   >still no inline mentions for nicecrew post
   >somehow they are still getting removed by... something
   >what the fuck
   
   ok I give up
   I hate pleroma
   fuck gleason for this shit being needed at all too :02_yell: :02_yell:
   •  (mint@ryona.agency)'s status on Friday, 19-May-2023 04:40:25 JST 

     in reply to

     • Yukkuri
     @zero Seems to be working on Eientei, @iamtakingiteasy done a few fixes to the MRF but I don't remember what did they do exactly.
     https://gitlab.eientei.org/eientei/pleroma/-/blob/eientei/lib/pleroma/web/activity_pub/mrf/force_mentions_in_content.ex
     MRF pipeline runs after the scrubber in object validator regardless, so it shouldn't require the whitelist for the class.
     Screenshot_20230518_223214.png
   • Zero :zt_think: :artix: (zero@strelizia.net)'s status on Friday, 19-May-2023 04:43:34 JST Zero :zt_think: :artix:

     in reply to

     • 
     @mint I literally printed out the "content" in both MRFs (force mentions one and normalize markup) and it was still there, it has to be getting remove somewhere else in the pipeline, maybe it's more shit akkoma broke silently eugh
      likes this.
   •  (mint@ryona.agency)'s status on Friday, 19-May-2023 04:49:59 JST 

     in reply to
     @zero https://git.froth.zone/sam/pleroma/src/branch/froth-akkoma/lib/pleroma/web/activity_pub/mrf.ex#L138
     Looks like it has NormalizeMarkup hardcoded to be enabled by default and ran after all the other policies, which is what actually does the filtering. I'd just remove it from the list and enable it the usual way, making sure the inline mention MRF runs after it.
   • Zero :zt_think: :artix: (zero@strelizia.net)'s status on Friday, 19-May-2023 04:59:31 JST Zero :zt_think: :artix:

     in reply to

     • 
     @mint does NormalizeMarkup even need to be added as an MRF? i thought the scrubber ran regardless
   •  (mint@ryona.agency)'s status on Friday, 19-May-2023 04:59:31 JST 

     in reply to
     @zero It does, but with that MRF with default configuration it essentially runs twice.
   •  (mint@ryona.agency)'s status on Friday, 19-May-2023 05:32:10 JST 

     in reply to
     @zero How about just removing that span wrap from the MRF?
     https://git.pleroma.social/pleroma/pleroma/-/commit/d5644a52aa4f031c69a2938b333636660156c703
     https://git.pleroma.social/pleroma/pleroma/-/merge_requests/3620
     From what I can see, it was only added for the Soybox compatibility.
   • Zero :zt_think: :artix: (zero@strelizia.net)'s status on Friday, 19-May-2023 05:32:11 JST Zero :zt_think: :artix:

     in reply to

     • 
     @mint doesn't work even after the changes, me vs eientei
     im assuming akkoma troons broke this somehow