C# source code protected override void VisitOr(ExpOr node, OpDest dest, ControlDest ctrl) { var truthy = ctrl.Truthy ?? Invariant($"lbl{label++}"); var branchLeft = new ControlDest(truthy, null, FallthroughTo.Falsey); Visit(node.Left, OpDest.Accumulator, new ControlDest(truthy, truthy, default)); PlugReg(dest, branchLeft, Accum); Visit(node.Right, OpDest.Accumulator, new ControlDest(truthy, truthy, default)); PlugReg(dest, ctrl, Accum); if (truthy != ctrl.Truthy) { Console.WriteLine($"{truthy}:"); } }

Notices where this attachment appears

1. Eniko | Kitsune Tails out now! (eniko@peoplemaking.games)'s status on Sunday, 29-Sep-2024 04:13:43 JST Eniko | Kitsune Tails out now!

   in reply to

   i'm less sure about this next bit but i realized for a logical or i wanted to treat both sides as their own thing with their own plugs

   the problem was nested logical ors would create redundant jumps no matter what i did. the critical bit here is `new ControlDest(truthy, truthy, default)` which creates an invalid control destination but still carries information about where to jump for truthy cases

   this means children don't jump when evaluated, but the truthy label is passed along, so the left hand side of a logical or can still jump when plugging, by setting the false label to nothing while keeping the true label, which makes it a valid control destination again